ngr: Fix Gradle test runner by only _conditionally_ invoking gradle wrapper
#27
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 88.59% 88.59%
=======================================
Files 17 17
Lines 561 561
=======================================
Hits 497 497
Misses 64 64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In order to support projects not including a Gradle wrapper, invoking `gradle wrapper` was sufficient to create one. However, this leads to problems on other projects which include a wrapper already: > Could not set unknown property 'baseName' for task ':jar' of type org.gradle.api.tasks.bundling.Jar. > > -- https://github.com/crate/crate-sample-apps/actions/runs/6974312523/job/18979796291#step:5:40 This patch intends to improve the situation by only installing a wrapper when ngr does not find a `gradlew` file in the directory.
amotl
changed the title
gradle wrappergradle wrapper
seut
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
In order to support projects not including a Gradle wrapper, invoking
gradle wrapperwas sufficient to create one.Problem
However, this leads to problems on other projects which include a wrapper already:
Solution
This patch intends to improve the situation by only installing a wrapper when ngr does not find a
gradlewfile in the directory.References
This improvement has been seeded from a real project, where it is already used and verified on.